Update unit_tests.rst#10799
Open
paperfront wants to merge 1 commit intodmlc:masterfrom
Open
Conversation
…tion of the deprecated CLI, which is used in the tests
trivialfis
reviewed
Sep 7, 2024
Member
trivialfis
left a comment
There was a problem hiding this comment.
Thank you for raising this issue. Do you think it's better to automatically skip the tests using pytest.mark.skip?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When following the instructions described in https://xgboost.readthedocs.io/en/stable/contrib/unit_tests.html#running-pytest to run the python unit tests locally, the following tests will fail:
The reason for these errors is because the default CMake build options exclude the building of the CLI (behavior introduced in #9485 )
To help avoid confusion, I updated the python section of the unit test documentation to mention this build option.
Here is a sample stack trace for the test_cli_model test case that shows that the executable is missing: